refactor: deduplicate entity seeding

.github/workflows/docker.test.command.yml

@@ -22,7 +22,7 @@ jobs:
 
       - name: Create entities
         run: |
-          docker compose exec api /usr/src/app/create-entities.js 40
+          docker compose exec api /usr/src/app/seeder.js 40
 
       - name: Run updater
         run: |

seeder/create-entities.js

@@ -1,15 +1,9 @@
-#!/usr/bin/env node
-
 const wbEdit = require('wikibase-edit')(require('./wikibase-edit.config'));
 
-const numEntities = parseInt(process.argv[2], 10)
-if (!Number.isFinite(numEntities)) {
-    throw new Error(`Expected numeric argument to be given, got ${process.argv[2]}`)
-}
-
-;(async function () {
+module.exports = async function (numEntities) {
+    const result = []
     for (let i = 1; i <= numEntities; i++) {
-        await wbEdit.entity.create({
+        const { entity } = await wbEdit.entity.create({
             type: 'item',
             labels: {
                 'en': new Date().toISOString()
@@ -18,15 +12,7 @@ if (!Number.isFinite(numEntities)) {
                 'en': new Date().toDateString() + new Date().toISOString()
             }
         })
+        result.push(entity)
     }
-
-    return `Sucessfully created ${numEntities} entities`
-})()
-    .then((result) => {
-        console.log(result)
-    })
-    .catch((err) => {
-        console.error("Failed to run command.")
-        console.error(err)
-        process.exit(1)
-    })
+    return result
+}

seeder/seeder.js

@@ -0,0 +1,21 @@
+#!/usr/bin/env node
+
+const createEntities = require('./create-entities');
+
+const numEntities = parseInt(process.argv[2], 10)
+if (!Number.isFinite(numEntities)) {
+    throw new Error(`Expected numeric argument to be given, got ${process.argv[2]}`)
+}
+
+;(async function () {
+    const result = await createEntities(numEntities)
+    return `Sucessfully created ${result.length} entities`
+})()
+    .then((result) => {
+        console.log(result)
+    })
+    .catch((err) => {
+        console.error("Failed to run command.")
+        console.error(err)
+        process.exit(1)
+    })

seeder/server.js

@@ -1,6 +1,6 @@
 const http = require('http');
 const assert = require('assert');
-const wbEdit = require( 'wikibase-edit' )( require( './wikibase-edit.config' ) );
+const createEntities = require('./create-entities');
 
 let batchId = 1;
 
@@ -50,26 +50,11 @@ http.createServer(function (req, res) {
                 return Promise.reject(err);
             }
             const numEntities = 20;
-            const entities = [];
-
-            for (let i = 1; i <= numEntities; ++i) {
-                const { entity } = await wbEdit.entity.create({
-                    type: 'item',
-                    labels: {
-                        'en': new Date().toISOString()
-                    },
-                    descriptions: {
-                        'en': new Date().toDateString() + new Date().toISOString()
-                    }
-                });
-
-                console.log('created item id', entity.id)
-                entities.push(entity.id)
-            }
+            const entities = await createEntities(numEntities);
 
             responseObject = {
                 'id': batchId++,
-                'entityIds': entities.join(','),
+                'entityIds': entities.map(e => e.id).join(','),
                 'wiki': {
                     'domain': process.env.API_WIKIBASE_DOMAIN,
                     'wiki_queryservice_namespace': {