-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the Memorize package #9018
Conversation
LGTM from me. 👍 You should improve your README though! Btw, I don't see it tightly coupled to the idea of call stacks, as it remembers and visualizes any file loc. E.g. Maybe there should be a way to re-order these bits, and remove some frames. I also wish the stack-view would be visible while navigating around. (Maybe an output panel at the bottom would be a good fit?) But these are just ideas... |
Thanks @kaste! All of your suggestions are already on my todo list :) |
You restrict this to Mac/Linux, but the current version runs on Windows too. (I'm on Windows.) Maybe change that? |
I didn't have a Windows machine to test this on so I chose to be conservative about claiming to support it, but given you ran it successfully, I'll tag it as supporting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Memorize
Packages added:
- Memorize
Processing package "Memorize"
- All checks passed
One last thing (sorry, should have mentioned that yesterday): if you add a main menu entry for the keybindings (in package settings), that makes them easier to find. |
@braver - done, added a menu entry for keybindings |
My package is a visual memory aid designed to help explore call stacks in code.
There are no packages like it in Package Control.