Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the Memorize package #9018

Merged
merged 4 commits into from
Dec 15, 2024
Merged

Adds the Memorize package #9018

merged 4 commits into from
Dec 15, 2024

Conversation

ckm2k1
Copy link
Contributor

@ckm2k1 ckm2k1 commented Dec 10, 2024

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.

My package is a visual memory aid designed to help explore call stacks in code.

There are no packages like it in Package Control.

@kaste
Copy link
Contributor

kaste commented Dec 11, 2024

LGTM from me. 👍 You should improve your README though!

Btw, I don't see it tightly coupled to the idea of call stacks, as it remembers and visualizes any file loc. E.g.

image

Maybe there should be a way to re-order these bits, and remove some frames. I also wish the stack-view would be visible while navigating around. (Maybe an output panel at the bottom would be a good fit?) But these are just ideas...

@ckm2k1
Copy link
Contributor Author

ckm2k1 commented Dec 12, 2024

Thanks @kaste! All of your suggestions are already on my todo list :)
A better README is coming shortly!

@kaste
Copy link
Contributor

kaste commented Dec 12, 2024

You restrict this to Mac/Linux, but the current version runs on Windows too. (I'm on Windows.) Maybe change that?

@ckm2k1
Copy link
Contributor Author

ckm2k1 commented Dec 13, 2024

You restrict this to Mac/Linux, but the current version runs on Windows too. (I'm on Windows.) Maybe change that?

I didn't have a Windows machine to test this on so I chose to be conservative about claiming to support it, but given you ran it successfully, I'll tag it as supporting.

repository/m.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Memorize

Packages added:
  - Memorize

Processing package "Memorize"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Dec 14, 2024

One last thing (sorry, should have mentioned that yesterday): if you add a main menu entry for the keybindings (in package settings), that makes them easier to find.

@braver braver added the mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side label Dec 14, 2024
@ckm2k1
Copy link
Contributor Author

ckm2k1 commented Dec 15, 2024

@braver - done, added a menu entry for keybindings

@braver braver merged commit 7d11782 into wbond:master Dec 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants