Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XSL package #9015

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Update XSL package #9015

merged 1 commit into from
Dec 15, 2024

Conversation

deathaxe
Copy link
Contributor

@deathaxe deathaxe commented Dec 4, 2024

This commit...

  1. transfers "XSL" package to https://github.com/SublimeText/XSL
  2. merges "XSLT Snippets" package into "XSL".

Despite its name "XSLT Snippets" provides also syntax definition, completions and symbol list definitions.

XSL was primarily intended as backward compatibility package as ST3083 dropped that syntax from core packages. It defines same main scope text.xml.xsl as syntax from "XSLT Snippets".

For ST4 XSL packages provides rewritten syntax for XML Stylesheets (XSL) and XML Schemas (XSD) with full support for XPath and RegExp highlighting.

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

This commit...

1. transfers "XSL" package to https://github.com/SublimeText/XSL
2. merges "XSLT Snippets" package into "XSL".

Despite its name "XSLT Snippets" provides also syntax definition,
completions and symbol list definitions.

XSL was primarily intended as backward compatibility package as
ST3083 dropped that syntax from core packages. It defines same
main scope `text.xml.xsl` as syntax from "XSLT Snippets".

For ST4 XSL packages now provides rewritten syntax for XSL(T)
and XSD with full support for XPath and RegExp highlighting.
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages removed:
  - XSL
  - XSLT Snippets

@FichteFoll
Copy link
Collaborator

@hoest please let us know within the next two weeks if you have any objections against merging your XSLT Snippets package into this new version of XSL.

@FichteFoll FichteFoll added mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side awaiting objection A package is being replaced or moved and awaits objection from a current maintainer migration One or more packages are migrated into another labels Dec 10, 2024
@hoest
Copy link
Contributor

hoest commented Dec 12, 2024

@hoest please let us know within the next two weeks if you have any objections against merging your XSLT Snippets package into this new version of XSL.

Please do merge my XSLT snippets in this new version. I approve.

@FichteFoll FichteFoll removed the awaiting objection A package is being replaced or moved and awaits objection from a current maintainer label Dec 15, 2024
@FichteFoll FichteFoll merged commit ae55c21 into wbond:master Dec 15, 2024
2 checks passed
@deathaxe deathaxe deleted the Update-XSL-package branch December 15, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side migration One or more packages are migrated into another
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants