Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate PHP-Twig users to Twig #8996

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Conversation

deathaxe
Copy link
Contributor

PHP-Twig ...

  1. is marked missing for a reasonable time and thus can't be installed.
  2. is a tmLanguage based syntax
  3. that hasn't seen any updates for about 8 years
  4. seems to fail on ST4 according to its issue trackers

This PR therefore proposes to merge PHP-Twig into Twig.

PHP-Twig ...

1. is marked missing for a reasonable time and thus can't be installed.
2. is a tmLanguage based syntax
3. that hasn't seen any updates for about 8 years
4. seems to fail on ST4 according to its issue trackers
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages removed:
  - PHP-Twig

Packages modified:
  - Twig

@braver
Copy link
Collaborator

braver commented Oct 28, 2024

Just to follow proper process here, @uhnomoli are you ok with your package being basically folded into the (well maintained) Twig package?

@braver braver added awaiting objection A package is being replaced or moved and awaits objection from a current maintainer takeover Package maintainership is changing mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Oct 28, 2024
@braver braver merged commit f4d15e9 into wbond:master Nov 15, 2024
2 checks passed
@deathaxe deathaxe deleted the pr/merge-php-twig branch November 17, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting objection A package is being replaced or moved and awaits objection from a current maintainer mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side takeover Package maintainership is changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants