Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Takeover SublimeFileBrowser #8993

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Takeover SublimeFileBrowser #8993

merged 1 commit into from
Nov 15, 2024

Conversation

kaste
Copy link
Contributor

@kaste kaste commented Oct 24, 2024

SublimeFileBrowser (forked from dired) is actually good but has bugs and is unmaintained 😢.
I have a few PR's open without any response.

The goal is to get this going again (but it is almost there) and to move it to python 3.8.
The update to 0.8.5 should be not too disruptive to existing users. There is just one change in
look and feel: I prefer to use the user's color scheme for the dired view. I still ship the custom
scheme so users can opt-in or revert to the old look. This, of course, also closes an issue because
some users would have liked it to behave like that from the start. I.e. the custom scheme was a
light one, and there was no dark one.

My package is https://github.com/kaste/SublimeFileBrowser

This is also a fork of the unmaintained dired package. All commands are named "dired_x".

@aziz and @vovkkk to notice and to comment.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages modified:
  - FileBrowser

@FichteFoll
Copy link
Collaborator

You should add a note about the primary fork source to your readme (in addition to the now-secondary and deleted one).

I also initially though that the open PRs (of which the oldest is 3 weeks old) haven't been around that long, but I also see that the other PRs haven't seen any replies from a maintainer either in the recent years, not to mention the issues that have been created since then, so it seems quite clear that this repository is unmaintained.

@aziz, as per ususal, you have 2 weeks to object to this replacement.

@FichteFoll FichteFoll added takeover Package maintainership is changing awaiting objection A package is being replaced or moved and awaits objection from a current maintainer mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Oct 24, 2024
@kaste
Copy link
Contributor Author

kaste commented Oct 24, 2024

Updated the README and switched to py38 in a new release.

@braver braver merged commit 12cf297 into wbond:master Nov 15, 2024
2 checks passed
@kaste
Copy link
Contributor Author

kaste commented Nov 15, 2024

👋 😉

@braver
Copy link
Collaborator

braver commented Nov 15, 2024

🎉

@FichteFoll FichteFoll removed the awaiting objection A package is being replaced or moved and awaits objection from a current maintainer label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side takeover Package maintainership is changing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants