Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SCSS users to Sass #8990

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

deathaxe
Copy link
Contributor

This commit removes heavily out-dated and unmaintained SCSS package, migrating its users to Sass package.

Alternatively, we could split current Sass package into 2 (Sass and SCSS) and continue providing both as separate dedicated syntax packages.

Not sure what a perfect strategy is, but it appears many users still relying on out-dated SCSS package or even having installed both packages, not being aware they basically intend to provide same value.

SCSS saw its last update 10 years ago and it is time to sunset it.

related with SublimeText/Sass#111

This commit removes heavily out-dated and unmaintained SCSS package,
migrating its users to Sass package.
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Packages removed:
  - SCSS
  - Sass

@deathaxe
Copy link
Contributor Author

deathaxe commented Oct 13, 2024

I wonder why review bot says both packages SCSS and Sass are removed ?? ... but he said the same in PR #8986.

@braver
Copy link
Collaborator

braver commented Oct 13, 2024

I wonder why review bot says both packages SCSS and Sass are removed

I wondered the same last time. The ways of the bot are deep and mysterious.

@braver
Copy link
Collaborator

braver commented Oct 13, 2024

@MarioRicalde are you ok with replacing your (by now 10 years old) SCSS package with the (actively maintained and up to date) Sass package?

@braver braver added mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side awaiting objection A package is being replaced or moved and awaits objection from a current maintainer labels Oct 13, 2024
@braver braver merged commit 70a22a2 into wbond:master Oct 28, 2024
2 checks passed
@deathaxe deathaxe deleted the pr/migrage-scss-to-sass branch October 29, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting objection A package is being replaced or moved and awaits objection from a current maintainer mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants