Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update t.json #8960

Merged
merged 3 commits into from
Sep 3, 2024
Merged

Update t.json #8960

merged 3 commits into from
Sep 3, 2024

Conversation

stuartelimu
Copy link
Contributor

Add Toggle Sidebar and Reveal Current File package

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is Toggle Sidebar and Reveal Current File

There are no packages like it in Package Control.

My package is similar to FocusFileOnSidebar. However it should still be added because they work differently

Add Toggle Sidebar and Reveal Current File package
@braver
Copy link
Collaborator

braver commented Aug 21, 2024

I have tagged a release with a semver version number.

No, you didn't 😉

@stuartelimu
Copy link
Contributor Author

I have tagged a release with a semver version number.

No, you didn't 😉

Sorted!🙈
https://github.com/stuartelimu/toggle-sidebar-and-reveal-file/releases/tag/v1.0.0

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Toggle Sidebar and Reveal Current File

Packages added:
  - Toggle Sidebar and Reveal Current File

Processing package "Toggle Sidebar and Reveal Current File"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Toggle Sidebar and Reveal Current File

Packages added:
  - Toggle Sidebar and Reveal Current File

Processing package "Toggle Sidebar and Reveal Current File"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Aug 22, 2024

The normal “toggle sidebar” command is also available via the command palette. It would also make sense for your command, I think.

@braver braver added feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Aug 22, 2024
@stuartelimu
Copy link
Contributor Author

Makes sense, I'll add it in the next release. Thank you

@braver braver merged commit 1b70a96 into wbond:master Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants