Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmPL #8938

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Add SmPL #8938

merged 1 commit into from
Aug 7, 2024

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jun 22, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is syntax for SmPL (as used by Coccinelle.

There is already a similarly named syntax package for SMPL but that is some other language (it is uclear which one). And the name is actually different.

@braver
Copy link
Collaborator

braver commented Jun 26, 2024

Package Control won't accept that with the existing package (the different case doesn't differentiate enough). Maybe we can name your package "Coccinelle SmPL"?

@braver
Copy link
Collaborator

braver commented Aug 7, 2024

👋🏻

@braver braver added the stale The pull request needs to be updated but has not been within the recent past (2 weeks) label Aug 7, 2024
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: SmPL (Coccinelle)
Results help

Packages added:
  - SmPL (Coccinelle)

Processing package "SmPL (Coccinelle)"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SmPL (Coccinelle).sublime-syntax

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: SmPL (Coccinelle)
Results help

Packages added:
  - SmPL (Coccinelle)

Processing package "SmPL (Coccinelle)"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: SmPL (Coccinelle).sublime-syntax

@braver
Copy link
Collaborator

braver commented Aug 7, 2024

Works for me 👍🏻

@braver braver merged commit fb959d0 into wbond:master Aug 7, 2024
3 checks passed
@jtojnar jtojnar deleted the smpl branch August 11, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback provided stale The pull request needs to be updated but has not been within the recent past (2 weeks)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants