-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dark Castle Color Scheme #8936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: Dark Castle Color Scheme
Results help
Packages added:
- Dark Castle Color Scheme
Processing package "Dark Castle Color Scheme"
- ERROR: `messages` folder exists, but `messages.json` does not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also have a look at the bot’s feedback please!
repository/d.json
Outdated
"name": "Dark Castle Color Scheme", | ||
"author": "Scott Grivner", | ||
"details": "https://github.com/scottgriv/Dark-Castle-Sublime", | ||
"labels": ["theme", "color scheme", "dark theme", "dark castle", "dark"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Sublime Text parlance this is a color scheme and not a theme, so it should also not have that label. Repeating your theme’s name as a label also feels a bit superfluous.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points. Thank you for your feedback. I'll make the appropriate changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: Dark Castle Color Scheme
Results help
Packages added:
- Dark Castle Color Scheme
Processing package "Dark Castle Color Scheme"
- ERROR: `messages` folder exists, but `messages.json` does not
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: ERROR
Repo link: Dark Castle Color Scheme
Results help
Packages added:
- Dark Castle Color Scheme
Processing package "Dark Castle Color Scheme"
- ERROR: `messages` folder exists, but `messages.json` does not
Package Control only looks at your tags, so if you made an improvement please also tag a new release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Dark Castle Color Scheme
Packages added:
- Dark Castle Color Scheme
Processing package "Dark Castle Color Scheme"
- All checks passed
Thanks for your help. |
My package is similar to color schemes in general... However it should still be added because ...
I'm creating a new multi-platform theme, that's unlike any theme I've personally come across.
I've built it up for a number of platforms, and I would love to have Sublime included in my list.
Thanks!