Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dark Castle Color Scheme #8936

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Add Dark Castle Color Scheme #8936

merged 2 commits into from
Jun 19, 2024

Conversation

scottgriv
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **

My package is similar to color schemes in general... However it should still be added because ...
I'm creating a new multi-platform theme, that's unlike any theme I've personally come across.
I've built it up for a number of platforms, and I would love to have Sublime included in my list.

Thanks!

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Dark Castle Color Scheme
Results help

Packages added:
  - Dark Castle Color Scheme

Processing package "Dark Castle Color Scheme"
  - ERROR: `messages` folder exists, but `messages.json` does not

Copy link
Collaborator

@braver braver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also have a look at the bot’s feedback please!

"name": "Dark Castle Color Scheme",
"author": "Scott Grivner",
"details": "https://github.com/scottgriv/Dark-Castle-Sublime",
"labels": ["theme", "color scheme", "dark theme", "dark castle", "dark"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Sublime Text parlance this is a color scheme and not a theme, so it should also not have that label. Repeating your theme’s name as a label also feels a bit superfluous.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good points. Thank you for your feedback. I'll make the appropriate changes.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Dark Castle Color Scheme
Results help

Packages added:
  - Dark Castle Color Scheme

Processing package "Dark Castle Color Scheme"
  - ERROR: `messages` folder exists, but `messages.json` does not

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Dark Castle Color Scheme
Results help

Packages added:
  - Dark Castle Color Scheme

Processing package "Dark Castle Color Scheme"
  - ERROR: `messages` folder exists, but `messages.json` does not

@braver
Copy link
Collaborator

braver commented Jun 19, 2024

Package Control only looks at your tags, so if you made an improvement please also tag a new release.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Dark Castle Color Scheme

Packages added:
  - Dark Castle Color Scheme

Processing package "Dark Castle Color Scheme"
  - All checks passed

@braver braver merged commit 7a63d1c into wbond:master Jun 19, 2024
5 checks passed
@scottgriv
Copy link
Contributor Author

Thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants