Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update b.json #8923

Merged
merged 5 commits into from
May 24, 2024
Merged

Update b.json #8923

merged 5 commits into from
May 24, 2024

Conversation

RohanVashisht1234
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read [the docs][1].
  • I have tagged a release with a [semver][2] version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use [.gitattributes][3] to exclude files from the package: images, test files, sublime-project/workspace.

My package is a syntax highlighter for the Bend programming language

There are no packages like it in Package Control.

@RohanVashisht1234
Copy link
Contributor Author

there might be mistakes, so if there are mistakes, please tell me, I'll create the release once all the issues are solved.

@RohanVashisht1234
Copy link
Contributor Author

I am making the release now

@deathaxe
Copy link
Contributor

The repository doesn't provide a valid Sublime Text syntax definition.

@RohanVashisht1234
Copy link
Contributor Author

Ok, I'll update the syntax soon

@braver braver requested a review from packagecontrol-bot May 22, 2024 19:39
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Bend programming language
Results help

Packages added:
  - Bend programming language

Processing package "Bend programming language"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: bend.sublime-syntax

@braver
Copy link
Collaborator

braver commented May 22, 2024

error parsing lexer: Packages/User/bend.sublime-syntax: Error trying to parse sublime-syntax: %YAML indicator is required in 

Let us know when your package is ready to review. I'll close it in the mean time, but we can re-open when you're ready.

@braver braver closed this May 22, 2024
@RohanVashisht1234
Copy link
Contributor Author

fine np

@RohanVashisht1234
Copy link
Contributor Author

RohanVashisht1234 commented May 24, 2024

Let us know when your package is ready to review.

I have updated the bend.sublime-syntax

@braver braver reopened this May 24, 2024
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Bend programming language
Results help

Packages added:
  - Bend programming language

Processing package "Bend programming language"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: bend.sublime-syntax

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Bend programming language
Results help

Packages added:
  - Bend programming language

Processing package "Bend programming language"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: bend.sublime-syntax

@RohanVashisht1234
Copy link
Contributor Author

ok, so there must be a fallback file named .tmLanguage, is there a way to convert .sublime-syntax to .tmLanguage?

@deathaxe
Copy link
Contributor

Not necessary, because ST builds before 3143 are unlikely to be in use these days.

Package Control 4 requires 3143+ as well.

You could restrict the package to ST builds larger or requal than 3092, to disable the message.

@deathaxe
Copy link
Contributor

Would it make sense to call the package just "Bend"?

@RohanVashisht1234
Copy link
Contributor Author

RohanVashisht1234 commented May 24, 2024

Would it make sense to call the package just "Bend"?

yes

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Bend
Results help

Packages added:
  - Bend

Processing package "Bend"
  - WARNING: '.sublime-syntax' support has been added in build 3092 and there is no '.tmLanguage' fallback file
    - File: bend.sublime-syntax

repository/b.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Bend

Packages added:
  - Bend

Processing package "Bend"
  - All checks passed

@RohanVashisht1234
Copy link
Contributor Author

ok, is it ready to merge?

@braver braver merged commit e46a04d into wbond:master May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants