Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pkl (Pickle) syntax highlight #8882

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

serjan-nasredin
Copy link
Contributor

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

Documentation: https://pkl-lang.org/

@braver
Copy link
Collaborator

braver commented Feb 28, 2024

Hi 👋

You need to tag a release for this to work.

@serjan-nasredin
Copy link
Contributor Author

serjan-nasredin commented Feb 28, 2024

Hello @braver 😄! I created a version on my repository: https://github.com/serjan-nasredin/pkl.tmbundle/releases/tag/v0.0.1.
I don't know yet how to create syntax highlighting like: JavaScript (It is very difficult to understand).

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: ERROR

Repo link: Pkl (Pickle)
Results help

Packages added:
  - Pkl (Pickle)

Processing package "Pkl (Pickle)"
  - ERROR: Invalid JSON (with comments)
    - File: pkl.sublime-completions
    - Exception: Expecting value: line 1 column 1 (char 0)

@serjan-nasredin
Copy link
Contributor Author

serjan-nasredin commented Feb 28, 2024

How? I use yaml

image
I didn't understand.

@braver
Copy link
Collaborator

braver commented Feb 28, 2024

Looks like pkl.sublime-completions is an empty file.

@braver
Copy link
Collaborator

braver commented Feb 28, 2024

I don't know yet how to create syntax highlighting like: JavaScript (It is very difficult to understand).

Well you picked a really complicated example :) If you want to learn more, the Sublime Text Discord is a great place to ask questions.

@serjan-nasredin
Copy link
Contributor Author

Looks like pkl.sublime-completions is an empty file.

https://github.com/serjan-nasredin/pkl.tmbundle/releases/tag/v0.0.2

@serjan-nasredin
Copy link
Contributor Author

the Sublime Text Discord is a great place to ask questions.

Can you give me a link? I want to be a member of this server :)

@braver
Copy link
Collaborator

braver commented Feb 28, 2024

This should be it: https://discord.com/invite/D43Pecu

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Pkl (Pickle)

Packages added:
  - Pkl (Pickle)

Processing package "Pkl (Pickle)"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Feb 28, 2024

This bit about testing will also be of use, it really helped me build more complicated syntaxes: http://www.sublimetext.com/docs/syntax.html#testing

@braver braver merged commit 4b1c28c into wbond:master Feb 28, 2024
3 of 4 checks passed
@serjan-nasredin
Copy link
Contributor Author

serjan-nasredin commented Feb 28, 2024

@braver thanks you! ❤️
I will definitely look at it.

@serjan-nasredin serjan-nasredin deleted the add_pkl_syntax branch February 28, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants