Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Yollama #8863

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Add Yollama #8863

merged 1 commit into from
Feb 19, 2024

Conversation

mwwwa
Copy link
Contributor

@mwwwa mwwwa commented Jan 3, 2024

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is ...

There are no packages like it in Package Control.

This package adds a command to query an Ollama instance (local LLM inference runner) for assistance or chit chat.

@braver
Copy link
Collaborator

braver commented Feb 3, 2024

Thanks for your submission. This looks relatively straight forward. The only thing to add here is that since your package has settings, they should be exposed via the menu and command palette (otherwise users won't know about the settings and won't be able to easily edit them).

@mwwwa
Copy link
Contributor Author

mwwwa commented Feb 18, 2024

Thanks for your submission. This looks relatively straight forward. The only thing to add here is that since your package has settings, they should be exposed via the menu and command palette (otherwise users won't know about the settings and won't be able to easily edit them).

Hi, thanks for the feedback! It's fixed now, user can access the preferences both from the command palette and from the preferences menu.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Yollama

Packages added:
  - Yollama

Processing package "Yollama"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Feb 19, 2024

Excellent, thanks. Note that for the "Package Settings" you should also just provide the id, instead of effectively resetting the caption and mnemonic.

@braver braver merged commit bedbd64 into wbond:master Feb 19, 2024
1 check passed
@FichteFoll
Copy link
Collaborator

FichteFoll commented Feb 21, 2024

Note that for the "Package Settings" you should also just provide the id, instead of effectively resetting the caption and mnemonic.

Actually, the name and mnemonic should be provided for this item since it's not part of the Default menu and it's not guaranteed that some other package has already defined the same menu item, e.g. when this package is the only one installed (besides PC).

@braver
Copy link
Collaborator

braver commented Feb 21, 2024

@FichteFoll oh, really, I didn't think of that. Thanks! I assumed it was just always there (because I never have less than a few packages installed for more than a few seconds). I guess 90% of packages overwrite the captions and mnemonics for all the menu items all the time anyway, so it's also not a big deal (as long as they match defaults).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants