-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Yollama #8863
Add Yollama #8863
Conversation
Thanks for your submission. This looks relatively straight forward. The only thing to add here is that since your package has settings, they should be exposed via the menu and command palette (otherwise users won't know about the settings and won't be able to easily edit them). |
Hi, thanks for the feedback! It's fixed now, user can access the preferences both from the command palette and from the preferences menu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Yollama
Packages added:
- Yollama
Processing package "Yollama"
- All checks passed
Excellent, thanks. Note that for the "Package Settings" you should also just provide the id, instead of effectively resetting the caption and mnemonic. |
Actually, the name and mnemonic should be provided for this item since it's not part of the Default menu and it's not guaranteed that some other package has already defined the same menu item, e.g. when this package is the only one installed (besides PC). |
@FichteFoll oh, really, I didn't think of that. Thanks! I assumed it was just always there (because I never have less than a few packages installed for more than a few seconds). I guess 90% of packages overwrite the captions and mnemonics for all the menu items all the time anyway, so it's also not a big deal (as long as they match defaults). |
My package is ...
There are no packages like it in Package Control.
This package adds a command to query an Ollama instance (local LLM inference runner) for assistance or chit chat.