Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heta language support #8853

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Heta language support #8853

merged 3 commits into from
Dec 6, 2023

Conversation

metelkin
Copy link
Contributor

@metelkin metelkin commented Nov 30, 2023

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • Any commands are available via the command palette.
  • Preferences and keybindings (if any) are listed in the menu and the command palette, and open in split view.
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").
  • I use .gitattributes to exclude files from the package: images, test files, sublime-project/workspace.

My package is the highlighter for the Heta modeling language, see https://hetalang.github.io/#/

There are no packages like it in Package Control.

@metelkin
Copy link
Contributor Author

@packagecontrol-bot

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Heta

Packages added:
  - Heta

Processing package "Heta"
  - All checks passed

@braver
Copy link
Collaborator

braver commented Dec 2, 2023

Unless you're targeting multiple editors with that tmLanguage file I highly recommend switching to the new yaml based sublime-syntax format. That's a lot easier to maintain than the ancient text-mate grammar.
Please also have a look at the scope naming guide, especially space.heta looks like it should be wrapper in a higher level scope. invalid.illegal is also missing the .heta suffix.

Please add "labels": ["language syntax"] to your entry here to indicate the type of package.

@metelkin
Copy link
Contributor Author

metelkin commented Dec 4, 2023

Thank you for your feedback.
Yes, we are using tmLanguage to support multiple editors. I guess it would be easier to proceed with the old approach.
I fixed the scopes you mentioned in projects master. I guess we will revise all of them in future releases.

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Heta

Packages added:
  - Heta

Processing package "Heta"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Heta

Packages added:
  - Heta

Processing package "Heta"
  - All checks passed

@braver braver merged commit cb6a16c into wbond:master Dec 6, 2023
3 checks passed
@jwortmann
Copy link
Contributor

On which version of Sublime Text was this tested? Is it only on my side, or doesn't the syntax work on the latest ST version (build 4169)?

I can see the following in the console after installing (or disabling & enabling) the package, and it is not assigned to files with the .heta extension:

error parsing lexer: Packages/Heta/heta.tmLanguage: Unexpected capture value

@metelkin
Copy link
Contributor Author

metelkin commented Dec 7, 2023

I've found the problem. This is because of exception in conversion from tmLanguage. Hope I'll fix it in the new release 0.1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants