Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Polar package #8845

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Add Polar package #8845

merged 2 commits into from
Nov 22, 2023

Conversation

edaniels
Copy link
Contributor

@edaniels edaniels commented Nov 7, 2023

  • I'm the package's author and/or maintainer.
  • I have have read the docs.
  • I have tagged a release with a semver version number.
  • My package repo has a description and a README describing what it's for and how to use it.
  • My package doesn't add context menu entries. *
  • My package doesn't add key bindings. **
  • If my package is a syntax it doesn't also add a color scheme. ***
  • If my package is a syntax it is named after the language it supports (without suffixes like "syntax" or "highlighting").

My package is a syntax highlighter for Oso's Polar language.

There are no packages like it in Package Control.

@edaniels edaniels changed the title Add sublime-polar-oso-cloud Add sublime-polar Nov 7, 2023
@edaniels edaniels changed the title Add sublime-polar Add Polar package Nov 7, 2023
@edaniels
Copy link
Contributor Author

edaniels commented Nov 9, 2023

@dennykorsukewitz, how were you able to request the bot to do a review? Thanks!

@dennykorsukewitz
Copy link
Contributor

@dennykorsukewitz, how were you able to request the bot to do a review? Thanks!

A magician never reveals his tricks. 🪄 🎩 🐰

But in this case it is because I have already created a PR that has been merged.

@dennykorsukewitz
https://github.com/wbond/package_control_channel/pulls?q=is%3Apr+author%3Adennykorsukewitz+is%3Aclosed

@edaniels
https://github.com/wbond/package_control_channel/pulls?q=is%3Apr+author%3Aedaniels+is%3Aclosed+

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: WARNING

Repo link: Polar
Results help

Packages added:
  - Polar

Processing package "Polar"
  - WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.

repository/p.json Outdated Show resolved Hide resolved
@braver
Copy link
Collaborator

braver commented Nov 19, 2023

Thanks for your submission. The main thing missing from your syntax is that all your scopes should end with .polar. That way packages can easily target your specific scopes if they want to. Other than that, since you already built tests I'm sure this is superfluous, but let me mention the Scope Naming guidelines: please ensure your syntax follows what's outlined in there as much as possible.

Let me know when you've added the suffixes and tagged a new release so we can merge and ship this thing 👍🏻

@braver braver added feedback provided mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side and removed mergeable The PR is in a mergeable state but awaiting some final comments/acknowledgement from either side labels Nov 19, 2023
@edaniels
Copy link
Contributor Author

Hey @braver, thanks for the review. Just addressed your changes in https://github.com/edaniels/sublime-polar/releases/tag/v0.0.2!

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Polar

Packages added:
  - Polar

Processing package "Polar"
  - All checks passed

Copy link
Collaborator

@packagecontrol-bot packagecontrol-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated testing result: SUCCESS

Repo link: Polar

Packages added:
  - Polar

Processing package "Polar"
  - All checks passed

@braver braver merged commit 1cf6f55 into wbond:master Nov 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants