-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Polar package #8845
Add Polar package #8845
Conversation
@dennykorsukewitz, how were you able to request the bot to do a review? Thanks! |
A magician never reveals his tricks. 🪄 🎩 🐰 But in this case it is because I have already created a PR that has been merged. @dennykorsukewitz @edaniels |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: WARNING
Repo link: Polar
Results help
Packages added:
- Polar
Processing package "Polar"
- WARNING: The package does not contain a top-level LICENSE file. A license helps users to contribute to the package.
Thanks for your submission. The main thing missing from your syntax is that all your scopes should end with Let me know when you've added the suffixes and tagged a new release so we can merge and ship this thing 👍🏻 |
Hey @braver, thanks for the review. Just addressed your changes in https://github.com/edaniels/sublime-polar/releases/tag/v0.0.2! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Polar
Packages added:
- Polar
Processing package "Polar"
- All checks passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated testing result: SUCCESS
Repo link: Polar
Packages added:
- Polar
Processing package "Polar"
- All checks passed
My package is a syntax highlighter for Oso's Polar language.
There are no packages like it in Package Control.