Improved service status and output management in Installation assistant #2953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The aim of this PR is to improve the management of the service exit code and output. This PR fix a bug: the Installation assistant didn't stop when a service failed. This is caused when using the verbose option. The
systemctl
command is concatenated with a tee comand| tee
and the exit code is always 0, even if thesystemctl
command fails.This PR separates the evaluation of the
systemctl
command and the print of the output of the command.Manual testing
An AIO installation has been performed to test the changes:
🟢 AIO installation log
Service failed - with verbose option
Service failed - without verbose option
Automatic testing