Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emailField to stringField to allow multiple voicemail emails #183

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

duduclx
Copy link

@duduclx duduclx commented Oct 31, 2024

allowing to set multiple emails for voicemails notification.

so we can set emails separated by ","

this is a little regression as we don't use any regex to validate the emails.

Copy link
Contributor

Build failed.
https://zuul.wazo.community/zuul/t/local/buildset/a39770c2e2ff492298c28066a3bc9d12

tox-linters FAILURE in 4m 05s
✔️ wazo-tox-py39 SUCCESS in 5m 11s
✔️ wazo-tox-integration-py39 SUCCESS in 4m 33s
✔️ debian-packaging-bullseye SUCCESS in 2m 37s

@DrPyser
Copy link
Contributor

DrPyser commented Nov 4, 2024

For this to make sense, wazo-confd /voicemails API and voicemail email notification logic would have to be updated to support multiple email addresses.
@duduclx if you have a related PR in wazo-confd please link it here as a Depends-On: field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants