Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: avoid instanciating a new DB engine for each fixture #176

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

db: avoid instanciating a new DB engine for each fixture #176

wants to merge 2 commits into from

Conversation

sduthil
Copy link
Member

@sduthil sduthil commented Dec 22, 2020

Why:

  • With too many fixtures, there is an error "sorry, too many clients
    already"

@wazo-zuul
Copy link
Contributor

wazo-zuul bot commented Dec 22, 2020

Build failed.

fblackburn1
fblackburn1 previously approved these changes Dec 23, 2020
View reviewed changes
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wazo-zuul
Copy link
Contributor

wazo-zuul bot commented Dec 23, 2020

Build failed.

@fblackburn1
Copy link
Member

recheck

@wazo-zuul
Copy link
Contributor

wazo-zuul bot commented Dec 23, 2020

Build failed.

@fblackburn1
Copy link
Member

recheck

@wazo-zuul
Copy link
Contributor

wazo-zuul bot commented Dec 23, 2020

Build failed.

@fblackburn1
Copy link
Member

recheck

@wazo-zuul
Copy link
Contributor

wazo-zuul bot commented Dec 23, 2020

Build failed.

@fblackburn1
Copy link
Member

recheck

@wazo-zuul
Copy link
Contributor

wazo-zuul bot commented Dec 23, 2020

Build failed.

@fblackburn1
Copy link
Member

I've allow enough time for now to try to figure out what is the issue, but found nothing.
test need a bigger refactor to remove too much magic and use pytest.
If I have some free time, I'll try to make a part of this refactor, but not for the next 2 weeks ;)

sduthil and others added 2 commits July 15, 2021 11:53
@sduthil @pc-m
db: avoid instanciating a new DB engine for each fixture
0fdc49e 
Why:

* With too many fixtures, there is an error "sorry, too many clients
already"
@fblackburn1 @pc-m
test: recreate db engine on recreate()
b74a52e
@pc-m pc-m force-pushed the WAZO-2165-too-many-fixtures branch from 6badae4 to b74a52e Compare July 15, 2021 15:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@wazo-community-zuul
Copy link
Contributor

Build failed.

@fblackburn1 fblackburn1 marked this pull request as draft October 13, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fblackburn1 fblackburn1 fblackburn1 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
mergeit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sduthil @fblackburn1