[feat] Add leftsuper
and rightsuper
Keys
#214
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Towards a more ergonomic working environment. This PR enables the use of the
super
key as a keysym.Help Needed
All tests successfully pass:
$ make test test result: ok. 51 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s Running unittests src/main.rs (target/debug/deps/swhks-328709fb84de0909) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
However, the added unit test does not seem to work as expected when added to
$HOME/.config/swhkd/swhkdrc
:Possibly, the key listener is unable to distinguish between
config::Modifier::Super
andKey::KEY_LEFTMETA
orKey::KEY_RIGHTMETA
key presses because bothKey::KEY_LEFTMETA
andKey::KEY_RIGHTMETA
keys are mapped to the sameconfig::Modifier::Super
modifier:Since I am unfamiliar with Rust, I believe it would be appropriate for someone with Rust experience to handle this situation.
Closes Issue
super
key as a keysym #209Related Issues
Heavily Inspired By