Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burstify queries #1143

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Burstify queries #1143

wants to merge 8 commits into from

Conversation

daleeidd
Copy link
Collaborator

@daleeidd daleeidd commented Feb 2, 2024

Takes work from and replaces #1059

Based off master instead of experimental as few things changed to adopt this mainstream. Requires an opt-in via scripting symbol "CREST_BURST_QUERY" to avoid a breaking change.

@daleeidd daleeidd force-pushed the burstify-queries branch 2 times, most recently from e7f88f1 to d56698e Compare April 10, 2024 06:07
@daleeidd daleeidd removed this from the 4.20 milestone Apr 21, 2024
@skaughtx0r
Copy link
Contributor

Do these changes make it so the Query for water heights can be done in a Job?

ecuzzillo and others added 8 commits May 19, 2024 18:53
Takes work from #1059 and retargets it to master branch.

Changes made from that PR:
- Add scripting symbol to opt-in to Burst queries
- Keep current API as default to avoid breaking change
- Formatting
- Excluded some superfluous changes

Co-authored-by: Dale Eidd <[email protected]>
Also add helpers to pass the equivalent of null for non-burst API.
@daleeidd daleeidd force-pushed the burstify-queries branch from d56698e to b41ed59 Compare May 19, 2024 10:54
@daleeidd
Copy link
Collaborator Author

Only Burst compiled. I have updated the branch to 4.20.1 if you would like to see if there is an improvement and give feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants