Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to ED1d for calculating membrane resistance as a function of ion concentration #1522

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

lbibl
Copy link
Contributor

@lbibl lbibl commented Nov 12, 2024

Fixes/Resolves:

(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@lbibl lbibl changed the title Memb resis Add method to ED1d for calculating membrane resistance as a function of ion concentration Nov 12, 2024
@lbibl lbibl marked this pull request as ready for review November 13, 2024 18:24
@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Nov 14, 2024
Copy link

@johnson12742 johnson12742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which references talks about the membrane resistance as a function of ion concentration? I quickly glanced through a few and didn't find one that talks about this function.

I was recommended the Galama paper for it (https://doi.org/10.1016/j.memsci.2014.05.046)
Also, this is an empirical relationship (is that correct?). Maybe make a note of that.

Everything else looks good.

@hunterbarber
Copy link
Contributor

@lbibl Can you clarify on the meaning of the spacer_conductivity_coefficient? I'm a little confused while going through the review.

@lbibl
Copy link
Contributor Author

lbibl commented Nov 25, 2024

@lbibl Can you clarify on the meaning of the spacer_conductivity_coefficient? I'm a little confused while going through the review.

Added notes in doc: "We used a coefficient multiplied by the solution conductance, denoted by :math:\sigma, to account for the spacer's conductance shadowing effect." There are cases where the shadowing effect is treated as a coefficient to resistance rather than conductance. This would be a clearer naming with the added notation.

@lbibl
Copy link
Contributor Author

lbibl commented Nov 25, 2024

Which references talks about the membrane resistance as a function of ion concentration? I quickly glanced through a few and didn't find one that talks about this function.

I was recommended the Galama paper for it (https://doi.org/10.1016/j.memsci.2014.05.046) Also, this is an empirical relationship (is that correct?). Maybe make a note of that.

Everything else looks good.

Updates on references underway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants