-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method to ED1d for calculating membrane resistance as a function of ion concentration #1522
base: main
Are you sure you want to change the base?
Conversation
watertap/flowsheets/electrodialysis/electrodialysis_1stack_conc_recirc_ui.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which references talks about the membrane resistance as a function of ion concentration? I quickly glanced through a few and didn't find one that talks about this function.
I was recommended the Galama paper for it (https://doi.org/10.1016/j.memsci.2014.05.046)
Also, this is an empirical relationship (is that correct?). Maybe make a note of that.
Everything else looks good.
@lbibl Can you clarify on the meaning of the |
Added notes in doc: "We used a coefficient multiplied by the solution conductance, denoted by :math:\sigma, to account for the spacer's conductance shadowing effect." There are cases where the shadowing effect is treated as a coefficient to resistance rather than conductance. This would be a clearer naming with the added notation. |
Updates on references underway. |
Fixes/Resolves:
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: