Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add TVC model #1516

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

add TVC model #1516

wants to merge 9 commits into from

Conversation

ElmiraShamlou
Copy link
Contributor

Fixes/Resolves:

(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)

Summary/Motivation:

Changes proposed in this PR:

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@ElmiraShamlou ElmiraShamlou self-assigned this Nov 5, 2024
@lbianchi-lbl
Copy link
Contributor

The failures are due to #1514 and are most likely unrelated to the changes in this PR.

@ElmiraShamlou ElmiraShamlou marked this pull request as ready for review November 6, 2024 02:13
@lbianchi-lbl lbianchi-lbl added the Priority:Normal Normal Priority Issue or PR label Nov 7, 2024
@ksbeattie
Copy link
Contributor

@ElmiraShamlou, just needs to add some documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carson-tucker carson-tucker Awaiting requested review from carson-tucker

@OOAmusat OOAmusat Awaiting requested review from OOAmusat

At least 2 approving reviews are required to merge this pull request.

Assignees

@ElmiraShamlou ElmiraShamlou

Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ElmiraShamlou @lbianchi-lbl @ksbeattie