Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bipolar membrane unit model and costing #1500

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Added bipolar membrane unit model and costing #1500

wants to merge 19 commits into from

Commits on Oct 2, 2024

  1. Added bipolar membrane unit model and costing

    @johnson12742
    johnson12742 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    2e5e903 View commit details
    Browse the repository at this point in the history

  2. Minor corrections based on autocheck

    @johnson12742
    johnson12742 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1b65114 View commit details
    Browse the repository at this point in the history

  3. Minor corrections based on autocheck v1.1

    @johnson12742
    johnson12742 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3e85b9f View commit details
    Browse the repository at this point in the history

  4. Minor corrections based on autocheck v1.2

    @johnson12742
    johnson12742 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1e3471d View commit details
    Browse the repository at this point in the history

  5. Minor corrections based on autocheck v1.3

    @johnson12742
    johnson12742 committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    ecb5db1 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Minor corrections based on autocheck v1.4

    @johnson12742
    johnson12742 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ff6a753 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Name change: Acidate/Basate to Acidic/Basic

    @johnson12742
    johnson12742 committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a833442 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. Updates to (mainly) documentation based on first set of reviews. + Co… 

    …rrect error in water flux. Updated unit model and test (changes are minor)
    @johnson12742
    johnson12742 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    2c2ca6d View commit details
    Browse the repository at this point in the history

  2. Updates to (mainly) documentation based on first set of reviews. + Co… 

    …rrect error in water flux. Updated unit model and test (changes are minor) v1.1
    @johnson12742
    johnson12742 committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    ecaeaa0 View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Updates to (mainly) documentation based on first set of reviews. + Co… 

    …rrect error in water flux. Updated unit model and test (changes are minor) v1.2
    @johnson12742
    johnson12742 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    895599a View commit details
    Browse the repository at this point in the history

  2. Updates to (mainly) documentation based on first set of reviews. + Co… 

    …rrect error in water flux. Updated unit model and test (changes are minor) v1.2
    @johnson12742
    johnson12742 committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    a56bb73 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Updates to (mainly) documentation based on second set of reviews. Cle… 

    …anup to remove unused performance metrics
    @johnson12742
    johnson12742 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    981da41 View commit details
    Browse the repository at this point in the history

  2. Updates to (mainly) documentation based on second set of reviews. Cle… 

    …anup to remove unused performance metrics v1.1
    @johnson12742
    johnson12742 committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    c09399b View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge branch 'main' into biploar_membrane

    @lbianchi-lbl
    lbianchi-lbl authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    8b043e3 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2024

  1. Change pytest to check for numerical accuracy instead of directly aga… 

    …inst experimental data
    @johnson12742
    johnson12742 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    d0b0449 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/biploar_membrane' into biploar_m… 

    …embrane
    @johnson12742
    johnson12742 committed Nov 9, 2024
    Configuration menu
    Copy the full SHA
    5b60c59 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. fix typos

    @johnson12742
    johnson12742 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    7bed754 View commit details
    Browse the repository at this point in the history

  2. fix typos

    @johnson12742
    johnson12742 committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    0e7c3ae View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. Corrections to the documentation

    @johnson12742
    johnson12742 committed Nov 16, 2024
    Configuration menu
    Copy the full SHA
    e4ad509 View commit details
    Browse the repository at this point in the history