Add molar flows for precipitate and reagent to simplify reaktoro integration #1498
+100
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avdudchenko
changed the title
|
@OOAmusat @zacharybinger can you review? |
adam-a-a
reviewed
Nov 21, 2024
| @@ -334,21 +329,28 @@ def build(self): | |||
| self.reagent_dose = Var( | |||
| self.reagent_list, | |||
| initialize=1, | |||
| domain=NonNegativeReals, | |||
| domain=Reals, | |||
There was a problem hiding this comment.
@avdudchenko Why reals instead of non?
There was a problem hiding this comment.
We can just find out if this ends up causing issues (unexpected and undesired negative values) later on.
adam-a-a
reviewed
Nov 21, 2024
adam-a-a
reviewed
Nov 21, 2024
adam-a-a
approved these changes
Nov 21, 2024
zacharybinger
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/Resolves:
N/A
(replace this with the issue # fixed or resolved, if no issue exists then a brief statement of what this PR does)
Summary/Motivation:
Adds molar flows of reagents and precipitates to simplify integration with reaktoro.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: