Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve CI failures due to invalid version being set from Git and WaterTAP updates (#18) #19

Merged
merged 13 commits into from
Nov 21, 2024

Conversation

lbianchi-lbl
Copy link
Contributor

No description provided.

@lbianchi-lbl lbianchi-lbl self-assigned this Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (bdf294b) to head (f235414).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          37       37           
  Lines        3716     3716           
=======================================
  Hits         3506     3506           
  Misses        210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lbianchi-lbl lbianchi-lbl changed the title Investigate #18 Resolve CI failures due to invalid version being set from Git (#18) Nov 20, 2024
@lbianchi-lbl lbianchi-lbl marked this pull request as ready for review November 20, 2024 20:30
@lbianchi-lbl lbianchi-lbl changed the title Resolve CI failures due to invalid version being set from Git (#18) Resolve CI failures due to invalid version being set from Git and WaterTAP updates (#18) Nov 20, 2024
@lbianchi-lbl
Copy link
Contributor Author

968a93f resolves the Codecov check failure by updating the import path to the WaterTAP flowsheets that are needed to fully test the loop tool. This is not related to #18 but is needed to fully resolve the current batch of CI failures.

@lbianchi-lbl lbianchi-lbl merged commit f7e90b3 into watertap-org:main Nov 21, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants