Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix typos #761

Merged
merged 1 commit into from
Sep 12, 2023
Merged

chore: fix typos #761

merged 1 commit into from
Sep 12, 2023

Conversation

yjhmelody
Copy link
Contributor

No description provided.

Copy link
Member

@Robbepop Robbepop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for the fixes @yjhmelody !

@paritytech-cicd-pr
Copy link

BENCHMARKS

NATIVEWASMTIME
BENCHMARKMASTERPRDIFFMASTERPRDIFFWASMTIME OVERHEAD
execute/
bare_call_0
1.56ms 1.51ms 🟢 -3.35% 1.13ms 1.06ms 🟢 -6.65% 🟢 -30%
execute/
bare_call_0/typed
1.16ms 1.12ms 🟢 -3.39% 677.07µs 702.30µs ⚪ 5.17% 🟢 -37%
execute/
bare_call_1
1.63ms 1.61ms 🔴 -1.06% 1.25ms 1.24ms 🟢 -0.16% 🟢 -23%
execute/
bare_call_16
2.65ms 2.59ms 🔴 -2.33% 3.53ms 3.49ms 🟢 -1.22% 🟢 35%
execute/
bare_call_16/typed
1.55ms 1.59ms 🔴 2.24% 1.83ms 1.80ms 🟢 -1.54% 🟢 13%
execute/
bare_call_1/typed
1.26ms 1.25ms ⚪ -0.72% 1.02ms 978.30µs 🟢 -4.14% 🟢 -22%
execute/
bare_call_4
1.80ms 1.78ms ⚪ -1.13% 1.64ms 1.61ms 🟢 -2.11% 🟢 -9%
execute/
bare_call_4/typed
1.24ms 1.23ms ⚪ -0.44% 924.60µs 930.22µs ⚪ 0.81% 🟢 -25%
execute/
br_table
1.41ms 1.36ms 🟢 -3.14% 1.19ms 1.14ms 🟢 -4.77% 🟢 -16%
execute/
count_until
621.11µs 621.21µs ⚪ -0.04% 1.37ms 1.37ms ⚪ -0.10% 🔴 120%
execute/
factorial_iterative
321.42µs 320.55µs ⚪ -0.17% 689.50µs 686.90µs ⚪ -0.42% 🔴 114%
execute/
factorial_recursive
524.16µs 522.33µs ⚪ -0.26% 824.78µs 821.55µs ⚪ -0.36% 🟡 57%
execute/
fibonacci_iter
1.44ms 1.40ms 🟢 -2.26% 3.31ms 3.31ms ⚪ -0.02% 🔴 136%
execute/
fibonacci_rec
4.24ms 4.35ms 🔴 2.48% 7.57ms 7.69ms 🔴 1.49% 🟡 77%
execute/
fibonacci_tail
1.11ms 974.07µs 🟢 -12.04% 1.90ms 1.90ms ⚪ 0.07% 🟡 95%
execute/
global_bump
716.05µs 723.31µs ⚪ 0.94% 1.66ms 1.67ms ⚪ -0.05% 🔴 130%
execute/
global_const
660.32µs 659.66µs ⚪ -0.05% 1.76ms 1.76ms ⚪ 0.00% 🔴 167%
execute/
host_calls
37.43µs 36.70µs 🟢 -1.68% 38.58µs 38.63µs ⚪ 0.24% 🟢 5%
execute/
memory_fill
1.16ms 1.16ms ⚪ 0.01% 2.69ms 2.68ms ⚪ -0.07% 🔴 131%
execute/
memory_sum
1.14ms 1.14ms ⚪ -0.16% 2.69ms 2.65ms ⚪ -1.08% 🔴 134%
execute/
memory_vec_add
2.31ms 2.31ms ⚪ -1.51% 5.70ms 5.70ms ⚪ 0.16% 🔴 147%
execute/
recursive_is_even
710.31µs 718.62µs 🔴 1.22% 1.25ms 1.24ms ⚪ -0.21% 🟡 72%
execute/
recursive_ok
102.93µs 103.57µs ⚪ 0.86% 193.45µs 189.58µs 🟢 -2.04% 🟡 83%
execute/
recursive_scan
137.23µs 138.56µs ⚪ 0.92% 267.53µs 245.44µs 🟢 -8.28% 🟡 77%
execute/
recursive_trap
10.24µs 10.08µs ⚪ -0.77% 19.65µs 19.46µs ⚪ -1.11% 🟡 93%
execute/
regex_redux
455.53µs 480.75µs 🔴 5.50% 967.63µs 970.36µs ⚪ 0.25% 🔴 102%
execute/
rev_complement
427.55µs 425.02µs ⚪ -1.18% 968.02µs 965.38µs ⚪ -0.29% 🔴 127%
execute/
tiny_keccak
316.28µs 318.90µs ⚪ 0.86% 900.81µs 841.97µs 🟢 -5.75% 🔴 164%
execute/
trunc_f2i
738.64µs 738.57µs ⚪ -0.06% 1.85ms 1.88ms 🔴 1.45% 🔴 155%
instantiate/
wasm_kernel
56.83µs 56.66µs ⚪ 1.48% 54.02µs 54.35µs ⚪ 0.27% 🟢 -4%
translate/
erc1155
190.90µs 191.13µs ⚪ 0.50% 316.09µs 317.65µs ⚪ 0.41% 🟡 66%
translate/
erc20
92.89µs 94.70µs 🔴 1.86% 154.47µs 155.47µs ⚪ 0.55% 🟡 64%
translate/
erc721
132.49µs 131.20µs ⚪ -1.45% 221.71µs 222.02µs ⚪ 0.13% 🟡 69%
translate/
spidermonkey
57.89ms 57.83ms ⚪ 0.03% 0.00ns 0.00ns ⚪ 0.70% 🟢 -100%
translate/
wasm_kernel
4.06ms 4.03ms ⚪ -0.06% 5.73ms 5.75ms ⚪ 0.46% 🟢 43%

Link to pipeline

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #761 (1040067) into master (61f7986) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   79.42%   79.42%           
=======================================
  Files         105      105           
  Lines        9075     9075           
=======================================
  Hits         7208     7208           
  Misses       1867     1867           
Files Changed Coverage Δ
crates/wasmi/src/engine/bytecode/utils.rs 69.30% <ø> (ø)
crates/wasmi/src/engine/config.rs 74.07% <ø> (ø)
crates/wasmi/src/engine/func_builder/translator.rs 86.85% <ø> (ø)
crates/wasmi/src/engine/resumable.rs 81.13% <ø> (ø)
crates/wasmi/src/engine/stack/values/mod.rs 86.84% <ø> (ø)
crates/wasmi/src/func/mod.rs 77.16% <ø> (ø)
crates/wasmi/src/func/typed_func.rs 61.53% <ø> (ø)
crates/wasmi/src/instance/exports.rs 65.38% <0.00%> (ø)
crates/wasmi/src/linker.rs 62.14% <ø> (ø)
crates/wasmi/src/store.rs 80.74% <ø> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Robbepop Robbepop merged commit 5f4a853 into wasmi-labs:master Sep 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants