Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add optional NaN canonicalization #1236

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

WIP: Add optional NaN canonicalization #1236

wants to merge 21 commits into from

Commits on Oct 13, 2024

  1. add Config::canonicalize_nans

    @Robbepop
    Robbepop committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    5c24bb4 View commit details
    Browse the repository at this point in the history

  2. improve unary and binary float instruction docs

    @Robbepop
    Robbepop committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    82ca9b9 View commit details
    Browse the repository at this point in the history

  3. fix doc comment

    @Robbepop
    Robbepop committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    7a095be View commit details
    Browse the repository at this point in the history

  4. add new instructions for NaN canonicalization

    @Robbepop
    Robbepop committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    42142f0 View commit details
    Browse the repository at this point in the history

  5. add CanonicalizeNan trait to wasmi_core

    @Robbepop
    Robbepop committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    be94dff View commit details
    Browse the repository at this point in the history

  6. apply rustfmt

    @Robbepop
    Robbepop committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    33346af View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. fix NaN -> Nan spelling

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    4d34ee2 View commit details
    Browse the repository at this point in the history

  2. add stubs for new instructions in executor

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9839e2c View commit details
    Browse the repository at this point in the history

  3. move f{32,64}.{min,max} down in file

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    c442a66 View commit details
    Browse the repository at this point in the history

  4. move f32_copysign down in file

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    bae8275 View commit details
    Browse the repository at this point in the history

  5. add default T=Self to ArithmeticOps and Float traits

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6395675 View commit details
    Browse the repository at this point in the history

  6. UntypedVal, TypedVal: add Nan canonicalization ops

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    be1a839 View commit details
    Browse the repository at this point in the history

  7. fix F64CopysignImmCanonicalizeNan rhs field type

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    8704403 View commit details
    Browse the repository at this point in the history

  8. add proper execution handlers for Nan canonicalization ops

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    549e3ed View commit details
    Browse the repository at this point in the history

  9. apply rustfmt

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d4e3109 View commit details
    Browse the repository at this point in the history

  10. add support for NaN canonicalization to Wasmi translation

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    12dcd31 View commit details
    Browse the repository at this point in the history

  11. move comment about canonical NaN bit patterns

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    51a2516 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'main' into rf-nan-canonicalization

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3e8c32d View commit details
    Browse the repository at this point in the history

  13. Merge branch 'main' into rf-nan-canonicalization

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2e504cb View commit details
    Browse the repository at this point in the history

  14. fix invalid code merge

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    3795e74 View commit details
    Browse the repository at this point in the history

  15. impl copysign_imm exec handlers via macro

    @Robbepop
    Robbepop committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    6a726a4 View commit details
    Browse the repository at this point in the history