Cloudevents lib update #447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksmtownsend
requested review from
autodidaddict,
thomastaylor312 and
stevelr
as code owners
|
I've never seen the issue with CI here, curious if it's a temporary github issue. |
Signed-off-by: Brooks Townsend <[email protected]>
brooksmtownsend
force-pushed
the
chore/cloudevents-update
branch
from
c29a5f1 to
50049c2
Compare
connorsmith256
approved these changes
Aug 20, 2022
autodidaddict
approved these changes
Aug 25, 2022
|
Looks like the build fail issue isn't temporary :( |
|
Implemented by #451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR updates the cloudevents library which removes avro bindings (and the need for a cc for
snappyer, a library we don't even use) to simplify the build process.I also fixed a small bug in the makefile found in #444