Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update wasm-tools-go location #38

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

lxfontes
Copy link
Member

@lxfontes lxfontes commented Nov 6, 2024

This means our examples / docs have to be updated to use go.bytecodealliance.org for go:generate.

Updating go:generate requires user interaction so lets do our best to not have to do it again.
In a follow-up PR we will abstract the upstream wit-bindgen-go command within this package, so users will use go.wasmcloud.dev/component/codegen.

Before

component-sdk-go ❯ ag 'wasm-tools-go' | wc -l
     272

After

component-sdk-go ❯ ag 'wasm-tools-go' | wc -l
       3

component-sdk-go ❯ ag 'wasm-tools-go'
_examples/http-server/go.mod
13:	github.com/bytecodealliance/wasm-tools-go v0.3.0 // indirect

_examples/http-server/go.sum
1:github.com/bytecodealliance/wasm-tools-go v0.3.0 h1:9aeDFYpbi3gtIW/nJCH+P+LhFMqezGoOfzqbUZLadho=
2:github.com/bytecodealliance/wasm-tools-go v0.3.0/go.mod h1:VY+9FlpLi6jnhCrZLkyJjF9rjU4aEekgaRTk28MS2JE=

Remaining mentions to wasm-tools-go will go away once we update wadge.

@lxfontes lxfontes requested a review from a team as a code owner November 6, 2024 21:40
@lxfontes lxfontes merged commit 1c2a371 into main Nov 6, 2024
9 checks passed
@lxfontes lxfontes deleted the lxfontes/bindgen-new-location branch November 6, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants