Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Stack Blur algorithm with its optimized version #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KaustubhPatange
Copy link

@KaustubhPatange KaustubhPatange commented Apr 27, 2021

What does this change?

The original stack blur algorithm with its optimized version.

What is the value of this and can you measure success?

The optimized stack blur or you can say multi-threaded stack blur. In this version, the horizontal & the vertical pixels are processed at the same time instead of the nested loop which is enough to provide a good performance benefit.

Considering this (above) the original stack algorithm skips 1-2 frame at the start (not much noticeable if done asynchronously). Since the new algorithm process rows & columns simultaneously this is not seen so far. I've kept the original implementation for you to compare the benchmarks.

Comparison

On average the optimized version takes 200ms less than the original one. I can't provide you a good metric but this is what I got when tested on Android API 21, 23, 27 & 29.

It is necessary that you first compare the two methods on your device as well. Since this project has no instrumentation tests it would be hard to automate it.

@arberg
Copy link

arberg commented Mar 11, 2022

I have merged your chances to my branch, and made some performance tests. See the other pull-request. I've made the code multi-threaded, but the blur is incorrect when running in multiple theads. I left the multi-thread code but disabled it. See my branch performance-test for performance-tests, but to work on the multi-threading stay on main so you don't run into trouble committing it to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants