Make subscription work for rails apps #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tatosjb thanks for raising, I'll do some local testing on this and get back asap! |
|
I've tested and released this PR. The chrome release should be approved in a day or two. Thanks for the work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The subscription feature does not work on default rails apps since they have a different pattern to support. I'll leave a screenshot of what it looks like currently.
This PR is meant to make all Rails apps compatible with the Rails ActionCable(the default way to use WebSockets with Ruby on Rails). You can find more here.
PS: Sorry for the linter changes. But I ran the project linter, and it seems ok.
Screenshot
There are no UI changes; I just changed the interceptor.
Checklist