Extract operationName for GET persisted operations
#149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can a maintainer have a look at this PR please? |
|
Apologies for the delay @gthau I was on holiday. Thank you for raising the PR, this will me added to the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR to address issue #148
Set
operationNameinIGraphqlRequestBodyfor GET persisted queries. It was missing and is needed to correctly display it in the Query/Mutation column.Screenshot
Provide a screenshot or gif of the new feature in both dark and light mode.
Checklist
I added a test to check that it does return correctly the operation name for persisted get requests.
However the project
Main.test.tsxfiles usesmockRequestswhich contains only POST requests, therefore this bug was not detectable with the current test suite. I think adding tests for GET requests too is bigger than the scope of this fix and should be done by a regular maintainer of the project.