New Debian container

[cfelipesp]

Added debian folder to warewulf-node-images with three files in it:

• Containerfile
• excludes
• container_exit.sh

It is a contribution to issue #867.

[anderbubble]

This is great, @cfelipesp!

Could you integrate this into https://github.com/hpcng/warewulf-node-images/blob/main/.github/workflows/container-publish.yml as well?

And can you sign-off on your commit to indicate your attestation to https://github.com/hpcng/warewulf-node-images/blob/main/DCO.md?

[cfelipesp]

And can you sign-off on your commit to indicate your attestation to https://github.com/hpcng/warewulf-node-images/blob/main/DCO.md?

I'm sorry. I'm new to git and github. Only now I read I should have made all my commits using commit -s . Is there anything I can do now to sign-off on them? Or should I just make sure I sign-off the new commits from now on? I'm sorry...

[anderbubble]

@cfelipesp I apologize for my absence here.

You can fix sign past commits with git rebase --signoff. Check out git help rebase for more info, and let me know if you have further questions. Or you can tell me what name / email address to use here and I'll sign them off for you.

Meanwhile, I'll get testing this, and I look forward to getting them merged in.

[anderbubble]

Do be advised, I've rebased this onto main; so you'll need to pull changes back to your machine if you want to continue working from the current branch.

[anderbubble]

Glorious. It appears to be working.

[janderson@wwctl1 debian-node-image]$ sudo wwctl node set wwnode1 --container debian-12.0
Are you sure you want to modify 1 nodes(s): y
? Are you sure you want to modify 1 nodes(s)? [y/N] y█

[janderson@wwctl1 debian-node-image]$ sudo wwctl overlay build
Building system overlays for wwnode1: [wwinit]
WARN   : context(system) and overlays([wwinit]) specified: prioritizing context(system)
Created image for overlay wwnode1/[wwinit]: /var/lib/warewulf/provision/overlays/wwnode1/__SYSTEM__.img
Compressed image for overlay wwnode1/[wwinit]: /var/lib/warewulf/provision/overlays/wwnode1/__SYSTEM__.img.gz
Building runtime overlays for wwnode1: [generic]
WARN   : context(runtime) and overlays([generic]) specified: prioritizing context(runtime)
Created image for overlay wwnode1/[generic]: /var/lib/warewulf/provision/overlays/wwnode1/__RUNTIME__.img
Compressed image for overlay wwnode1/[generic]: /var/lib/warewulf/provision/overlays/wwnode1/__RUNTIME__.img.gz

[janderson@wwctl1 debian-node-image]$ sudo ssh root@wwnode1
Linux wwnode1 6.1.0-14-amd64 #1 SMP PREEMPT_DYNAMIC Debian 6.1.64-1 (2023-11-30) x86_64

The programs included with the Debian GNU/Linux system are free software;
the exact distribution terms for each program are described in the
individual files in /usr/share/doc/*/copyright.

Debian GNU/Linux comes with ABSOLUTELY NO WARRANTY, to the extent
permitted by applicable law.

root@wwnode1:~# cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

[anderbubble]

@cfelipesp I squashed your commits together, and added you to the contributors file. I think this is ready to merge., except that I still need to get a signoff on it. Just let me know here for the record and I'll do it.

edit: looks like I spoke too soon. The container built for me locally, but isn't building in the GH action. I'll look into why.

[anderbubble]

#11 16.05 E: Unable to locate package linux-image-amd64

Aha: I expect it's failing to build because it can't install the amd64 kernel in an aarch64 container. And well it shouldn't.

[anderbubble]

I updated the container files to install the correct kernel dependent on the intended architecture, and it's working now.

[cfelipesp]

@cfelipesp I apologize for my absence here.

You can fix sign past commits with git rebase --signoff. Check out git help rebase for more info, and let me know if you have further questions. Or you can tell me what name / email address to use here and I'll sign them off for you.

Meanwhile, I'll get testing this, and I look forward to getting them merged in.

Hi, @anderbubble. I hope this is still in time, my e-mail is [email protected] . Could you please sign them off for me, then? I'm afraid I could make a mess if I tried to do that myself. Thanks

[anderbubble]

@cfelipesp it's merged. Thanks for contributing!

[cfelipesp]

@cfelipesp it's merged. Thanks for contributing!

My pleasure, @anderbubble !
Thank you for tutoring me in my first contribution to an open source project. And specially for being so patient with me. I have learned immensely.