Tutorial 1 #8
Open
Tutorial 1 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanbok
reviewed
Nov 14, 2019
| //} | ||
|
|
||
| let decoder = JSONDecoder() | ||
| if let champsData = champsData, |
There was a problem hiding this comment.
Unwrapping(i.e. if let, guard let 등)을 최소화 하여 코드를 작성해보시면 더 좋은 인지복잡도점수를 얻을 것 같습니다.
훈련의 차원에서
- 현재 인지복잡도 점수를 계산해보고
- 점수를 1점씩 줄이는 시도를 계속 하면
도움될 것 같습니다.
There was a problem hiding this comment.
계산이 귀찮으면 if, for등으로 시작되는 코드블럭을 최소화 한다고 생각하셔도 됩니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step1:
챔피언 이름 찾기.