-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: UX improvements for arguments passing #44
Chore: UX improvements for arguments passing #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @remybar !
Some small improvements pls:
- Can you add an "X" button to the top right of the modal, which will close the modal? We can use the same "X" style as we have in the top banner called "About cairovm.codes"
- In the modal you call it "arguments" but in the input it's called "parameters...". Let's make it consistent and only use one word
- Let's make the "?" icon more subtle. It's not an important element on the screen so it doesn't need to be very noisy. I suggest to use a dark gray color (maybe same color as the color for "Enter program parameters..."). We can probably also make the icon smaller and with thinner lines — similar to the permalink icon.
5dfe0c4
to
01c3cdd
Compare
01c3cdd
to
10008f9
Compare
Yes, I agree ! |
073da44
to
281bdb7
Compare
looking good! |
Related to #43.
I've added a new
Modal
component to be able to show some popups easily.I've checked on mobile and it is correctly displayed (with a smaller font size).
Don't hesitate to tell me if something has to be changed !