Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: UX improvements for arguments passing #44

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

remybar
Copy link
Collaborator

@remybar remybar commented Feb 13, 2024

Related to #43.

I've added a new Modal component to be able to show some popups easily.
I've checked on mobile and it is correctly displayed (with a smaller font size).

Don't hesitate to tell me if something has to be changed !

@remybar remybar requested a review from a team as a code owner February 13, 2024 04:23
@mazurroman mazurroman linked an issue Feb 13, 2024 that may be closed by this pull request
2 tasks
@mazurroman mazurroman self-requested a review February 13, 2024 07:01
Copy link
Contributor

@mazurroman mazurroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @remybar !

Some small improvements pls:

  • Can you add an "X" button to the top right of the modal, which will close the modal? We can use the same "X" style as we have in the top banner called "About cairovm.codes"
  • In the modal you call it "arguments" but in the input it's called "parameters...". Let's make it consistent and only use one word
  • Let's make the "?" icon more subtle. It's not an important element on the screen so it doesn't need to be very noisy. I suggest to use a dark gray color (maybe same color as the color for "Enter program parameters..."). We can probably also make the icon smaller and with thinner lines — similar to the permalink icon.

@remybar remybar force-pushed the remybar-arguments_ux_improvements branch from 5dfe0c4 to 01c3cdd Compare February 14, 2024 07:31
@remybar remybar force-pushed the remybar-arguments_ux_improvements branch from 01c3cdd to 10008f9 Compare February 14, 2024 07:39
@remybar
Copy link
Collaborator Author

remybar commented Feb 14, 2024

Thanks @remybar !

Some small improvements pls:

* [ ]  Can you add an "X" button to the top right of the modal, which will close the modal? We can use the same "X" style as we have in the top banner called "About cairovm.codes"

* [ ]  In the modal you call it "arguments" but in the input it's called "parameters...". Let's make it consistent and only use one word

* [ ]  Let's make the "?" icon more subtle. It's not an important element on the screen so it doesn't need to be very noisy. I suggest to use a dark gray color (maybe same color as the color for "Enter program parameters..."). We can probably also make the icon smaller and with thinner lines — similar to the permalink icon.

Yes, I agree !
I did these modifications. Tell me if the "?" icon is small/thin enough for you ;-) I decreased its size a little bit and I tried to make it thinner but I'm not sure it is possible as the stroke-width attribute seems ignore 🤔

@remybar remybar force-pushed the remybar-arguments_ux_improvements branch from 073da44 to 281bdb7 Compare February 14, 2024 13:24
@mazurroman
Copy link
Contributor

looking good!

@mazurroman mazurroman self-requested a review February 14, 2024 13:46
@mazurroman mazurroman merged commit aae11ed into walnuthq:main Feb 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: UX improvements for arguments passing
2 participants