Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile and runtime error messaging #150

Merged

Conversation

jaipaljadeja
Copy link
Contributor

Resolves #145

I had to move up setLogs(data.logs) to get the logs.

I dont know if this is a known issue but whenever compilation fails, it throws error in the below code segment because is_execution_successful & tracer_data in data is undefined as not returned by the run API and it would jump to catch block thus not updating the logs.

image

Also added a small style fix because in some screens console log messages were being cutoff like this
image

Copy link
Contributor

@barabanovro barabanovro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@barabanovro barabanovro merged commit b68fec1 into walnuthq:main Apr 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Fix compilation failure handling and error messaging
2 participants