-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highlight runtime errors #126
highlight runtime errors #126
Conversation
@saimeunt thank you for the contribution! After looking at the app it looks like the error highlighting in Instructions as well as in CASM is working pretty well. However, I do not see the error being highlighted in Sierra, can you look into that? Also, can you move the execution to the "error" statement? Currently the execution is at the beginning at "Step 1", but we want to move it to the error in case of an error. Please reach out in case of any questions. |
@mazurroman I've moved the execution step to the error instruction on program run. Regarding the SIERRA issue, I noticed the last execution trace is always pointing to the final return exiting the program and this instruction is not mapped to any SIERRA code 🤔 (no active index either). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @saimeunt, sorry for the confusion, we were wrong here. We should highlight the trace entry that is before the last one. In this case, it will always point to a Sierra statement. Please make these changes, and the PR will be ready to merge.
@barabanovro thanks for the heads up, we should be getting there now 💪 |
lgtm! |
Fixes #99