-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fullscreen height #112
Merged
Merged
Fullscreen height #112
Changes from 2 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
dc8815e
Fullscreen height
LukaszMMazur 9bffb3b
Made better fullscreen
LukaszMMazur 9b24e3c
Improved fullscreen
LukaszMMazur 6c45cdf
updated branch Fullscreen
LukaszMMazur ceb6b1d
updated Fullscreen branch
LukaszMMazur 6c43304
missing space
LukaszMMazur aff0c36
fixed bugs in fullscreen
LukaszMMazur 77bf943
Merge branch 'main' into Fullscreen (fixed merge conflicts)
LukaszMMazur 93798ca
fullscreen mode bugs in small window
LukaszMMazur 6ca6cfb
lint bugs
LukaszMMazur 0694d2a
Merge branch 'main' into Fullscreen
LukaszMMazur 6c2b077
debug info view bug
LukaszMMazur 62283b8
added threecolumn layout
LukaszMMazur 4122a3c
lint fix
LukaszMMazur b2b316d
Merge branch 'main' into Fullscreen
LukaszMMazur b7fb7c0
Refactored Fullscreen Implementaion & Footer Dark/Light Mode
jaipaljadeja 2ebf7c5
Merge branch 'main' into help/fullscreen
jaipaljadeja 26f7dff
Merge pull request #1 from jaipaljadeja/help/fullscreen
LukaszMMazur 9b53ee4
Merge branch 'main' into Fullscreen
LukaszMMazur 3b2d35c
Merge branch 'Fullscreen' of https://github.com/LukaszMMazur/cairovm.…
LukaszMMazur File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,6 +74,8 @@ const Editor = ({ readOnly = false }: Props) => { | |
const editorRef = useRef<SCEditorRef>() | ||
const [showArgumentsHelper, setShowArgumentsHelper] = useState(false) | ||
|
||
const { isFullScreen } = useContext(AppUiContext) | ||
|
||
useEffect(() => { | ||
const query = router.query | ||
|
||
|
@@ -241,7 +243,11 @@ const Editor = ({ readOnly = false }: Props) => { | |
return ( | ||
<> | ||
<div className="bg-gray-100 dark:bg-black-700 rounded-lg"> | ||
<div className="flex flex-col md:flex-row"> | ||
<div | ||
className={`flex flex-col md:flex-row ${ | ||
isFullScreen ? 'h-[92vh]' : '' | ||
}`} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you use the |
||
> | ||
<div className="w-full md:w-1/2 flex flex-col"> | ||
<div className="border-b border-gray-200 dark:border-black-500 flex items-center pl-6 pr-2 h-14 md:border-r"> | ||
<Header | ||
|
@@ -298,7 +304,7 @@ const Editor = ({ readOnly = false }: Props) => { | |
</div> | ||
|
||
<div className="w-full md:w-1/2 flex flex-col"> | ||
<Tracer mainHeight={cairoEditorHeight} /> | ||
<Tracer /> | ||
</div> | ||
</div> | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better not to render the component at all in case its full screen, instead of using
hidden
class.See the "Inline If with Logical && Operator" section here: https://legacy.reactjs.org/docs/conditional-rendering.html#inline-if-with-logical--operator
So it will look like: