Azure Integration not failing on failed tests (#252)

* Azure Integration not failing on failed tests * Set $ErrorActionPreference = "Stop" [full ci] * Throw error from ps scrippt [full ci] * Simplify [full ci] * Last Exit Code [full ci] * Try [full ci] * Simplify [full ci] * Integration test fix [full ci] * Exit code from PS is boolean [full ci] * Put the rest of the workflow back in * Missing empty line * Another missing empty line Co-authored-by: Plamen Ivanov <[email protected]>
walmartlabs · Jun 19, 2021 · cb22421 · cb22421
1 parent 70b4ce8
commit cb22421
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 5 deletions.
diff --git a/docs/docs/Module_Grpc.md b/docs/docs/Module_Grpc.md
@@ -172,7 +172,7 @@ Application.create()
             endpoint: "localhost:5000",
             definition: SampleServiceDefinition,
         }))
-        done()
+        .done()
     .dispatch({
         onSomeInput: (msg: ISomeInput, ctx: IDispatchContext): Promise<void> => {
             const client = ctx.services.get<ISampleService>("some-service");

diff --git a/packages/azure/integrate.sh b/packages/azure/integrate.sh
@@ -19,6 +19,7 @@ then
 fi
 
 jest --config=../../jest.integration.config.js --rootDir=.
+exit_code=$?
 
 if [[ $RUNNING_IN_CI != 1 ]]
 then
@@ -30,4 +31,6 @@ then
         vagrant destroy -f
         cd ..
     fi
-fi
+fi
+
+exit $exit_code
diff --git a/packages/azure/package.json b/packages/azure/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@walmartlabs/cookie-cutter-azure",
-    "version": "1.4.0-beta.6",
+    "version": "1.4.0-beta.7",
     "license": "Apache-2.0",
     "main": "dist/index.js",
     "types": "dist/index.d.ts",

diff --git a/packages/azure/run_integration_tests.ps1 b/packages/azure/run_integration_tests.ps1
@@ -7,4 +7,8 @@ cd ../azure
 yarn build
 yarn integrate
 
+If ("$?" -ne "True") {
+    throw "Yarn Integrate Failed"
+}
+
 Start-Sleep -s 60
diff --git a/packages/azure/src/utils/BlobClient.ts b/packages/azure/src/utils/BlobClient.ts
@@ -31,7 +31,7 @@ export class BlobClient implements IBlobClient, IRequireInitialization {
         if (config.connectionString) {
             this.client = BlobServiceClient.fromConnectionString(config.connectionString);
         } else if (config.url) {
-            if (config.url.indexOf("https://") === 0) {
+            if (config.url.indexOf("http") === 0) {
                 this.client = new BlobServiceClient(
                     config.url,
                     new StorageSharedKeyCredential(config.storageAccount, config.storageAccessKey)

diff --git a/packages/azure/src/utils/QueueClient.ts b/packages/azure/src/utils/QueueClient.ts
@@ -141,7 +141,7 @@ export class QueueClient implements IRequireInitialization {
                 storagePipelineOptions
             );
         } else if (config.url) {
-            if (config.url.indexOf("https://") === 0) {
+            if (config.url.indexOf("http") === 0) {
                 this.queueService = new QueueServiceClient(
                     config.url,
                     new StorageSharedKeyCredential(config.storageAccount, config.storageAccessKey),