Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mocks-task: record task events for mocked tasks #1027

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Conversation

brig
Copy link
Contributor

@brig brig commented Nov 7, 2024

  • Now mocked tasks will send events with in/out parameters. Everything will look as if the original task was called;
  • Now it's not possible to mock a method that doesn't exist in the original task. I think this is better to make the behavior closer to a flow without mocks;
  • If a task is mocked, the original task won’t even be created to prevent it from executing anything in its constructor.

@brig brig added the docs label Nov 7, 2024
@brig brig requested a review from a team November 7, 2024 23:27
@brig brig merged commit e011486 into master Nov 8, 2024
4 checks passed
@brig brig deleted the brig/mocks-events branch November 8, 2024 22:06
@brig
Copy link
Contributor Author

brig commented Nov 23, 2024

docs: walmartlabs/concord-website#176

@brig brig removed the docs label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants