Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Java Format to 1.25.0 #1470

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

msridhar
Copy link
Member

Just to stay up to date

@msridhar msridhar enabled auto-merge (squash) November 23, 2024 19:38
@msridhar msridhar requested a review from liblit November 23, 2024 19:38
Copy link

Test Results

  428 files   -   385    428 suites   - 385   2h 30m 53s ⏱️ - 1h 31m 33s
  736 tests ±    0    719 ✅ ±    0  17 💤 ± 0  0 ❌ ±0 
2 519 runs   - 2 517  2 462 ✅  - 2 453  57 💤  - 64  0 ❌ ±0 

Results for commit fffb2d6. ± Comparison against base commit b99a80f.

Copy link
Contributor

@liblit liblit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something ain't right in the automated CI jobs:

Caused by: java.lang.UnsupportedClassVersionError: com/google/googlejavaformat/java/JavaFormatterOptions$Style has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

@msridhar
Copy link
Member Author

Something ain't right in the automated CI jobs:

Caused by: java.lang.UnsupportedClassVersionError: com/google/googlejavaformat/java/JavaFormatterOptions$Style has been compiled by a more recent version of the Java Runtime (class file version 61.0), this version of the Java Runtime only recognizes class file versions up to 55.0

Yeah, GJF requires Java 17 now. To update we'll have to only enable spotless tasks when the Gradle JVM is JDK 17+. Does that sound reasonable, @liblit? Shouldn't lead to any gaps on CI since we run jobs with the Gradle JVM at 17, 21, etc.

@liblit
Copy link
Contributor

liblit commented Nov 23, 2024

Does that sound reasonable, @liblit?

Yes.

@liblit liblit self-requested a review November 23, 2024 20:43
@msridhar msridhar merged commit 56efabd into wala:master Nov 23, 2024
10 checks passed
@msridhar msridhar deleted the gjf-1.25.0 branch November 23, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants