Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warnings about unstable Gradle APIs #1319

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

liblit
Copy link
Contributor

@liblit liblit commented Sep 5, 2023

We're intentionally using an unstable Gradle Kotlin feature that allows direct ... = ... assignment to Property instances. This feature may be considered unstable, but it's stable enough to have been enabled by default since Gradle 8.2.

We're intentionally using [an unstable Gradle Kotlin feature that
allows direct `... = ...` assignment to `Property`
instances](https://blog.gradle.org/simpler-kotlin-dsl-property-assignment).
This feature may be considered unstable, but it's stable enough to
have been [enabled by default since Gradle
8.2](https://docs.gradle.org/8.2.1/release-notes.html#simple-property-assignment-in-kotlin-dsl-enabled-by-default).
@liblit liblit added the gradle WALA’s Gradle build system label Sep 5, 2023
@liblit liblit requested a review from msridhar September 5, 2023 00:19
@liblit liblit self-assigned this Sep 5, 2023
@liblit liblit enabled auto-merge (rebase) September 5, 2023 00:21
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Test Results

   455 files  ±0     455 suites  ±0   2h 33m 55s ⏱️ - 8m 15s
   731 tests ±0     714 ✔️ ±0  17 💤 ±0  0 ±0 
2 808 runs  ±0  2 738 ✔️ ±0  70 💤 ±0  0 ±0 

Results for commit 81680d7. ± Comparison against base commit df52cbb.

♻️ This comment has been updated with latest results.

Copy link
Member

@msridhar msridhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit annoying we can't add this suppression globally and need to do it in each file

@liblit liblit merged commit ab4e3e8 into wala:master Sep 5, 2023
8 checks passed
@liblit liblit deleted the silently-allow-unstable-Gradle-APIs branch September 5, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gradle WALA’s Gradle build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants