Fix crash with void return type in TypeSignature code (#1468)

I'm not sure why there was an assert fail before, but it's straightforward enough to do the right thing.
wala · Nov 20, 2024 · 35684ea · 35684ea
1 parent e925830
commit 35684ea
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/core/src/main/java/com/ibm/wala/types/generics/TypeSignature.java b/core/src/main/java/com/ibm/wala/types/generics/TypeSignature.java
@@ -44,8 +44,7 @@ public static TypeSignature make(String s) throws IllegalArgumentException {
     assert !s.isEmpty();
     switch (s.charAt(0)) {
       case TypeReference.VoidTypeCode:
-        Assertions.UNREACHABLE();
-        return null;
+        return BaseType.VOID;
       case TypeReference.BooleanTypeCode:
         return BaseType.BOOLEAN;
       case TypeReference.ByteTypeCode:

diff --git a/core/src/test/java/com/ibm/wala/types/generics/MethodTypeSignatureTest.java b/core/src/test/java/com/ibm/wala/types/generics/MethodTypeSignatureTest.java
@@ -16,4 +16,9 @@ void getArguments() {
         MethodTypeSignature.make("(I)V").getArguments(),
         arrayContaining(is(TypeSignature.make("I"))));
   }
+
+  @Test
+  void getVoidReturn() {
+    assertThat(MethodTypeSignature.make("(I)V").getReturnType(), is(TypeSignature.make("V")));
+  }
 }