Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecations warning #57

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Deprecations warning #57

merged 3 commits into from
Nov 8, 2023

Conversation

ocefpaf
Copy link
Contributor

@ocefpaf ocefpaf commented Mar 6, 2023

In this PR:

  • remove six, this library is Python 3 only for a while
  • remove all Deprecation, Future, and PendingDeprecation warnings that would become errors in the near future as libraries are updated
  • turn all warnings but RuntimeWarnings and UserWarnings into errors in the CIs.

@davidovitch
Copy link
Member

@ocefpaf I just created PR #62 and realised it overlaps with your more extensive work here. Should we merge this one?

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Nov 8, 2023

@ocefpaf I just created PR #62 and realised it overlaps with your more extensive work here. Should we merge this one?

I'll leave it to you. Feel free to do whatever you think is easier.

@davidovitch davidovitch merged commit ad305a5 into wafo-project:master Nov 8, 2023
@ocefpaf ocefpaf deleted the deprecations_warning branch November 8, 2023 22:09
@davidovitch davidovitch mentioned this pull request Nov 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ocefpaf @davidovitch