-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add GitHub Actions testing #54
Conversation
I assume this PR will fix #52. Looks pretty good to me but I don't have any experience with the Github/Travis build/test environment. |
Yes. That fix is included.
I'll probably iterate more after this is merged this one is ready for a review and merge. Let me know if you want to add some extra comments on what this is doing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mpmath and pytest are also required to be able to run the tests
(oops, didn't mean to review, just comment)
They are not removed. I moved them to a requirements-dev.txt which won't inject them as mandatory dependencies but will install them in a dev environment for running the tests. |
My bad, missed that file. I have no experience with Actions testing, or Travis for that matter, but it looks really neat. Out of curiosity, is this a separate approach to run testing than the existing .travis.yml? Is the plan to use Actions for building as well? |
The plan is to remove Travis-CI and substitute it with GitHub Actions. Travis-CI was the state of the art for CI testing but since it was sold to another company the OSS service is really degraded and unreliable. GitHub Actions is faster, more flexible, and seems to be the new OSS standard. |
The CIs results can be viewed at https://github.com/ocefpaf/pywafo/actions/runs/3643452287/jobs/6151687789 Once merge they'll also run here on every PR. Things that are still missing but I cannot fix them at the moment:
This is as far as I can take this PR. I can investigate more the macOS builds and Windows compilation later but I'm clueless to the failures and if they are relevant or just bad expected results due to different scipy versions. |
It would be nice to merge this pull request! |
Thanks for the reminder. I will have a look this weekend and merge. |
This probably won't pass in the first iteration but let's see how far we can go trying to get the tests to run again.