Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #2614 #2656

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Revert #2614 #2656

merged 1 commit into from
Nov 23, 2024

Conversation

JanuarySnow
Copy link
Contributor

@JanuarySnow JanuarySnow commented Nov 23, 2024

Revert #2614

Nexus descriptions in the meta can get messy with formatting and line-breaks, the reverted PR just sent all that info to WJ to write to the ini, but the iniparser assumed one key/value per line - that was fine with name and version info, but it wasnt ready for formatted descriptions.

This caused mod descriptions with linebreaks to fail compilation - such as an existing Cyberpunk list for example

Instead of messing around with changing around a lot more in the iniparser or string sanitizing, its easier to just revert, for such a niche benefit.

@JanuarySnow JanuarySnow merged commit 967b0bb into main Nov 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant