Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump eslint version #170

Merged
merged 5 commits into from
Oct 16, 2021
Merged

Bump eslint version #170

merged 5 commits into from
Oct 16, 2021

Conversation

jorgebodega
Copy link
Collaborator

Resolves #168

@jorgebodega jorgebodega added dependencies Pull requests that update a dependency file next This will be probably fixed on next Release labels Oct 12, 2021
@jorgebodega jorgebodega self-assigned this Oct 12, 2021
@jorgebodega jorgebodega linked an issue Oct 13, 2021 that may be closed by this pull request
Bump eslint version #168
Closed
RaphaelWoude
RaphaelWoude approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@RaphaelWoude RaphaelWoude left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Do note that v8 of eslint does not support Node.js version 10.
https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0

@jorgebodega
Copy link
Collaborator Author

LGTM! Do note that v8 of eslint does not support Node.js version 10. eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0

I know it. That is another check to do. Even node is not supporting 10.x, and semantic release needs 14.x.

The ideal? Drop support to everything that is less than 14, because is the current LTS until 16. Then, support both

@RaphaelWoude
Copy link
Collaborator

Dropping support up until 14 is probably the best for the next version.

@jorgebodega
Copy link
Collaborator Author

#161 (comment)

I think this will be the proper way

@jorgebodega jorgebodega merged commit 8cf1880 into next Oct 16, 2021
@jorgebodega jorgebodega deleted the 168-bump-eslint-version branch October 16, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphaelWoude RaphaelWoude RaphaelWoude approved these changes

Assignees

@jorgebodega jorgebodega

Labels
dependencies Pull requests that update a dependency file next This will be probably fixed on next Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump eslint version
2 participants
@jorgebodega @RaphaelWoude