-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PolkaMask: Bridging the Polkadot Ecosystem with Metamask - A Revolutionary Signer Snap Project #2058
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read and hereby sign the Contributor License Agreement. |
Update polkamask.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application @Nick-1979 a couple of initial comments:
- Are you aware that ChainSafe just released their MetaMask snap for Polkadot? Can you do a quick comparison to explain how your project would be different?
- I'm happy to see that you want to work with polkadot.cloud which is about to be released and looks super cool. Are you planning to contribute to the actual polkadot-cloud repo?
- Deliverable 0b. looks like it was accidentally formatted incorrectly as it's in the wrong column. Can you adjust this? Thanks!
Hi @keeganquigley, Thank you for your prompt response.
|
Thanks for the updates @Nick-1979 its looking better now, and thanks for comparing to ChainSafe. I agree it would be great to have a solution that is more plug and play for devs who don't want to spend too much time implementing it. I will go ahead and mark the application as ready for review and ping the rest of the committee. In the meantime, I have just a couple more comments:
|
Thank you @keeganquigley, for advancing the proposal to the next stage for review. Your support and guidance are greatly appreciated. As you mentioned, MetaMask lacks native support for Non-EVM Polkadot chains/parachains. The Polkagate Signer Snap effectively integrates MetaMask with the Polkadot ecosystem, offering a seamless solution. Our updates to extension-dapp and polkadot-cloud are designed to provide comprehensive support, not only for our Snap but also for any future Snaps adhering to the current standards of Polkadot JS, widely adopted by the ecosystem's dApps. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @Nick-1979 I'm happy to go ahead with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the application. I have two comments/questions:
- Have you considered treasury funding for this project? My main concern here is that it is never a good idea to rely on grants and ultimately the community should decide if the project is valuable or not.
- Second the application seems relatively expensive to me compared to your previous grants, when I consider the estimated FTE and time. Would you be willing to reduce the costs?
David, we want to express our sincere appreciation for your invaluable feedback. Your concerns about treasury funding and project costs are well-received, and we would like to address these important points:
Your insights are invaluable to us, and we are wholeheartedly dedicated to ensuring transparency and alignment with the interests of the community. We eagerly look forward to engaging in further discussions and are entirely open to any necessary adjustments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed and quick reply. Would you potentially be willing to reduce the total costs at least a little bit?
David, we value your feedback, and in response to your concerns, we have adjusted the total budget to $28K. This demonstrates our dedication to cost-efficiency while maintaining the quality of the project. We appreciate your understanding and ongoing support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @Nick-1979 still happy to go ahead with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nick-1979 thank you for the grant application.
You mention in the application that a difference from your proposal to Polkadot Snap (Chainsafe one) is "An important distinction is that integrating with this wallet Snap often requires dApps to undergo modifications to utilize the Snap, which can be a significant barrier to integration.". Could you elaborate more on that? What would be the modifications needed to integrate with Chainsafe's snap? How difficult are those modifications to be performed?
Furthermore, you mention "To uphold Snap security, MetaMask requires audits from selected teams. We are in the process of arranging these audits to ensure a high level of security.". How much it would cost and how do you plan to afford this?
I think interesting the idea of having more than one snap for Polkadot but this will only have value if it is different than what we already have and if would be actually launched, what includes the audit.
Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions. |
🚀 Quick Update! As promised earlier, the Snap security audit has been successfully completed by Safyer. You can access the audit report via the following link: Audit Report. Additionally, we’ve submitted a request for Snap whitelisting through Metamask, and the process is underway. Expect it to be completed soon! 🙌 Thank you for your support! 🌟 |
Project Abstract
Introducing a revolutionary project with the vision of bridging the gap between the Polkadot ecosystem and the vast user base of Metamask, which boasts over 30 million users. We are committed to creating a seamless connection between these two vibrant communities, opening up new possibilities and opportunities for all involved.
This project includes a signer Snap for the Polkadot ecosystem on MetaMask. It seamlessly integrates with all existing dApps without requiring any code modifications. The Signer is capable of signing not only Polkadot and Kusama extrinsics but also extrinsics from all other Substrate-based chains that align with Polkadot.js APIs.
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)