Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFP]socks5 support for JsonRpsee #2056

Merged
merged 11 commits into from
Oct 19, 2023
Merged

Conversation

flipchan
Copy link
Contributor

This is an RFP for adding support for socks5 proxy connections in the Rust library JsonRpsee.

The RFP is created in order to motivate people to work on pr paritytech/jsonrpsee#870.

By enabling socks5 support several ecosystem client libraries can connect to .onion(tor) rpc endpoints. Giving end users more privacy when connecting to nodes.

Noc2
Noc2 previously approved these changes Oct 18, 2023
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for creating the RFP. I would be happy to merge it.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. rfp Request for proposal, not a grant application labels Oct 18, 2023
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flipchan thanks, I'm fine with the scope as well. I just added a couple of stylistic improvement suggestions; feel free to have a look.

docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
docs/RFPs/jsonrpsee-proxy-support.md Outdated Show resolved Hide resolved
@takahser takahser self-assigned this Oct 18, 2023
@flipchan
Copy link
Contributor Author

Requested changes has been added @takahser

@flipchan flipchan requested a review from takahser October 18, 2023 11:20
Copy link
Contributor

@keeganquigley keeganquigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flipchan this is awesome. Thanks for writing it. And thanks @takahser for edits.

@Noc2 Noc2 merged commit 990c635 into w3f:master Oct 19, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members. rfp Request for proposal, not a grant application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants