Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interstellar Wallet Phase 2 - amended - remove docker delivery #2028

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

nashjl
Copy link
Contributor

@nashjl nashjl commented Oct 3, 2023

Project Abstract

This is an amendment to the previous application that remove the docker delivery from the Milestones.
w3f/Grant-Milestone-Delivery#918 (review)

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or Polkadot (USDC & USDT) or BTC address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@nashjl nashjl changed the title amended - remove docker delivery Interstellar Wallet Phase 2 - amended - remove docker delivery Oct 3, 2023
@nashjl
Copy link
Contributor Author

nashjl commented Oct 3, 2023

I have read and hereby sign the Contributor License Agreement.

@nashjl
Copy link
Contributor Author

nashjl commented Oct 3, 2023

recheck

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I'm generally okay with going ahead with it. But could you also share the reason here?

@Noc2 Noc2 added changes requested The team needs to clarify a few things first. amendment This PR proposes changes to an existing application. labels Oct 4, 2023
Add the reason for the amendment suggested by the evaluator
@nashjl
Copy link
Contributor Author

nashjl commented Oct 4, 2023

Sure @Noc2, we have added the reason for the amendment in the contract:

As we prioritize the user experience and aim to showcase the FPS improvement compared to the previous milestone, there is no need for a Docker here. Instead, we provide an offline demo app to simplify the evaluation.
w3f/Grant-Milestone-Delivery#918 (review)

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick reply.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Oct 4, 2023
@takahser takahser self-assigned this Oct 4, 2023
@Noc2 Noc2 merged commit a1ec733 into w3f:master Oct 5, 2023
9 checks passed
@nashjl nashjl mentioned this pull request Oct 24, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants