Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CosmWasmVM-CoreProduct.md #1890

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Conversation

JafarAz
Copy link
Contributor

@JafarAz JafarAz commented Aug 4, 2023

Amending timelines as requested due to the delay in the grant submission.

@keeganquigley @semuelle sirs, what would be the correct way to amend the timeline? The current estimated duration of the milestones is not that far off from what it would take. One reason for the delay is that we had to pause the development for a period in Q2 however, we're actively working on getting this ready by end of this month.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Ideally, you add the total time to the duration of the milestone and the total number since it was merged. Apart from this, could anyone of the original contributors to the application confirm the update here? See #1430

@Noc2 Noc2 added changes requested The team needs to clarify a few things first. amendment This PR proposes changes to an existing application. labels Aug 7, 2023
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If no work is being done for an extended period, it probably makes more sense to add a starting date rather than changing the duration from 11 weeks to 7 months. Also, you have crossed out the duration of the milestones, @JafarAz, but it would still be nice to have an estimate how long it takes. You can adapt those as well, of course.

@JafarAz
Copy link
Contributor Author

JafarAz commented Aug 16, 2023

@Noc2 unfortunately the original contributors to the application are no longer members of Composable. https://docs.composable.finance/ecosystem/the-composable-team our docs verify that I am part of the Composable team however, happy to verify via an alternate method

@nikw3f nikw3f self-assigned this Aug 17, 2023
@nikw3f
Copy link
Contributor

nikw3f commented Aug 23, 2023

Please verify via alternative method then.

@semuelle
Copy link
Member

Please verify via alternative method then.

I have confirmed that Jafar works for Composable.

@JafarAz, is the timeline until August still up to date?

@semuelle
Copy link
Member

semuelle commented Sep 6, 2023

pinging @JafarAz

@JafarAz
Copy link
Contributor Author

JafarAz commented Sep 12, 2023

Hi, apologies for the delayed response. I will update the file to show it as September. I'm currently working on the submission as we speak.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@JafarAz
Copy link
Contributor Author

JafarAz commented Sep 12, 2023

I have read and hereby sign the Contributor License Agreement.

@JafarAz JafarAz requested a review from semuelle September 12, 2023 20:58
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@semuelle semuelle added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Sep 13, 2023
@nikw3f
Copy link
Contributor

nikw3f commented Sep 13, 2023

LGTM

@takahser takahser merged commit 3c4884f into w3f:master Sep 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants